Validate Whirlpool rounds#2525
Open
marko1olo wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2508.
Whirlpool exposes
Roundsas a numeric option with a UI range of 1-10, but the operation accepted direct API/recipe values outside that range. Passing a negative round count through tocrypto-apiproduced the reported all-zero Whirlpool output.This adds runtime validation for integer rounds in the supported 1-10 range, while preserving existing recipes that omit the second argument by defaulting to 10 rounds.
AI disclosure:
Validation:
node --no-warnings --no-deprecation --openssl-legacy-provider tests/operations/index.mjspassed: 1962 passing.npx eslint src/core/operations/Whirlpool.mjs tests/operations/tests/Hash.mjspassed.npx grunt configTestspassed.git diff --checkpassed.