Handle invalid View Bit Plane colour input#2588
Open
KairosOps wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2503.
View Bit Planeassumed the colour argument always matched one of the RGBA channel names. A pretty URL such asView_Bit_Plane('',7)leaves that argument as an empty string, so the operation ended up reading from an invalid pixel offset instead of reporting a bad argument.This adds an explicit colour lookup check before scanning the image and returns the same kind of user-facing
OperationErrorthat the operation already uses for invalid bit numbers. I also added a regression test using the empty colour argument from the failing URL path.Checked locally:
View Bit Planeoperation testsView_Bit_Plane('',7)npx grunt configTestsnode --check src/core/operations/ViewBitPlane.mjsnode --check tests/operations/tests/Image.mjsgit diff --check