Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tabs in member page #2022

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Remove tabs in member page #2022

wants to merge 4 commits into from

Conversation

Steph4104
Copy link
Collaborator

@Steph4104 Steph4104 commented Jul 2, 2019

For issue # https://zube.io/tbs-sct/gctools/c/4968

I put in commit the code for removing "Recent" and "Online" tabs.
This is for test only.

When we are sure we want to remove it, I will create a last commit to erase those commit.

@Steph4104 Steph4104 requested a review from piet0024 July 2, 2019 16:40
Copy link
Collaborator

@piet0024 piet0024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depending on plugin order, this either does not remove the tabs (if it is higher in the plugin order) and if it is at the bottom of the plugin order, then /members throws a page not found error. I'm not sure if there is another mod that overrides the members page / what the desired outcome is of removing the tabs is.

@Steph4104
Copy link
Collaborator Author

@piet0024 , you are right, on GCconnex, the c_member_byDepartment overwrite members plugin. Should be fix now.

Copy link
Collaborator

@piet0024 piet0024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this removes the tabs 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants