Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gear-programs): vft-treasury program implementation #127

Merged
merged 16 commits into from
Sep 24, 2024
Merged

feat(gear-programs): vft-treasury program implementation #127

merged 16 commits into from
Sep 24, 2024

Conversation

playX18
Copy link
Member

@playX18 playX18 commented Sep 16, 2024

No description provided.

@playX18 playX18 requested a review from mertwole September 16, 2024 07:02
mertwole
mertwole requested changes Sep 16, 2024
View reviewed changes
@playX18
Copy link
Member Author

playX18 commented Sep 18, 2024

Copied msg tracker and reply handling logic from vft-gateway and refactored treasury to send messages to builtin bridge + added error handling

mertwole
mertwole requested changes Sep 19, 2024
View reviewed changes
@playX18 playX18 requested a review from mertwole September 20, 2024 00:50
ByteNacked
ByteNacked requested changes Sep 20, 2024
View reviewed changes
Copy link
Member

@ByteNacked ByteNacked left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall, please check some suggestions in comments.

mertwole
mertwole requested changes Sep 23, 2024
View reviewed changes
@playX18 playX18 requested a review from mertwole September 24, 2024 04:20
@playX18 playX18 requested a review from mertwole September 24, 2024 08:18
@playX18 playX18 merged commit 2deef67 into main Sep 24, 2024
2 checks passed
@playX18 playX18 deleted the ap/vft-treasury branch September 24, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ByteNacked ByteNacked ByteNacked approved these changes

@mertwole mertwole mertwole approved these changes

@vobradovich vobradovich Awaiting requested review from vobradovich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@playX18 @ByteNacked @mertwole