Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require user confirmation to delete other php version in Debian #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prakasa1904
Copy link

@prakasa1904 prakasa1904 commented Oct 11, 2024

Description

By auto delete another version from the machine, it causing existing service which depend to the version break and system down. Better if the purge mechanism require to confirm manually from executor (user) instead.

Example Case

We have legacy service running with PHP 7.x fpm, depend to binary /usr/sbin/php-fpm7.2 running under systemd with command below:

.......................................................
.......................................................
[Service]
Type=notify
ExecStart=/usr/sbin/php-fpm7.0 --nodaemonize --fpm-config /etc/php/7.0/fpm/pool.d/example.conf --pid /run/php/php7.0-example.pid
.......................................................
.......................................................

When new service with newest PHP binary dependency coming, require devOps to install the binary, by using this roles the previous binary will be removed automatically in the task Purge PHP version packages (besides the currently chosen php_version).. Then when the legacy service owner deploy their service, it will break.

Powered by dPanel

Copy link

github-actions bot commented Feb 8, 2025

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

@github-actions github-actions bot added the stale label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant