Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change product name and product description #608

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

tyanbiao
Copy link
Contributor

@tyanbiao tyanbiao commented Mar 4, 2024

No description provided.

@geerlingguy
Copy link
Owner

@tyanbiao - Thanks for the PR! Could you keep the PCBway prefix in at least the filename still, so it follows the convention most of the adapters do (like vendor-hat-name.md)?

Also, if you could add redirects (for example:

redirect_from: /hats/mirko-hat5m1-hat
), that would be helpful, that way old search traffic and links would redirect to the new pages.

@tyanbiao
Copy link
Contributor Author

tyanbiao commented Mar 4, 2024

Hi, I have modified the filenames.

@geerlingguy geerlingguy merged commit 71843a9 into geerlingguy:master Mar 4, 2024
1 check passed
@tyanbiao tyanbiao deleted the pr branch March 6, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants