[BOT-API] Build executable binary #43 #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabhxyz
reviewed
May 23, 2024
sourabhxyz
reviewed
May 23, 2024
Dockerfile
Outdated
| @@ -86,6 +86,7 @@ RUN git init && \ | |||
| git commit -m "Dummy commit" | |||
| RUN cabal update | |||
| RUN cabal build all --enable-tests --enable-benchmarks | |||
| RUN cp /DEX/dist-newstyle/build/x86_64-linux/ghc-9.2.8/geniusyield-server-lib-0.4.0/x/geniusyield-server/build/geniusyield-server/geniusyield-server /DEX/geniusyield-server | |||
There was a problem hiding this comment.
This might create issues for different architectures.
|
There seems to me more concerns than benefit with this change. Proposed solution would bring in issues with different architectures, different version of built binary etc. |
|
Completed via #87, this PR can now be closed, but feel free to reopen it in case I missed something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: