Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry-run option #102

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Add dry-run option #102

merged 4 commits into from
Feb 14, 2025

Conversation

erik-brink
Copy link
Collaborator

@erik-brink erik-brink commented Feb 11, 2025

Contents

Summary

This pull request introduces a new dry_run option to several CLI commands in the NGPIris project. This option allows users to simulate the execution of commands without making actual changes, which is useful for testing and verification. The most important changes include adding the dry_run flag to the upload, download, delete_object, and delete_folder commands and modifying their behavior accordingly.

New dry_run option:

This update is:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Test Procedure

Installation and initiation

pip install NGPIris

Tests

Tests can as of right now, only be performed using pytest on a local instance of Iris. CI/CD for this is currently not possible.

Expected outcome:

PyTest resolves without crashes

Confirmations:

@erik-brink erik-brink self-assigned this Feb 11, 2025
@erik-brink erik-brink merged commit e5b07f2 into dev Feb 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant