Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

375 add spa type analysis to nanopore track #395

Merged
merged 12 commits into from
Feb 19, 2025

Conversation

Emkago
Copy link
Contributor

@Emkago Emkago commented Feb 3, 2025

Description

Added spa type analysis to nanopore track.

Summary of the changes made:

Primary function of PR

  • Hotfix
  • Minor functionality improvement
  • Major functionality improvement / New type of analysis
  • Backward-breaking functionality

Testing

Tested with Illumina and Nanopore data.

Sign-offs

@Emkago Emkago requested a review from a team as a code owner February 3, 2025 14:59
@Emkago Emkago linked an issue Feb 3, 2025 that may be closed by this pull request
@Emkago Emkago force-pushed the 375-add-spa-type-analysis-to-nanopore-track branch from c6c58db to 6057059 Compare February 6, 2025 11:03
Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes needed. See comments...

Copy link
Collaborator

@ryanjameskennedy ryanjameskennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Emkago Emkago merged commit 922fe79 into master Feb 19, 2025
3 checks passed
@Emkago Emkago deleted the 375-add-spa-type-analysis-to-nanopore-track branch February 19, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add spa-type analysis to Nanopore track
2 participants