Build contracts CI against branch biomcp binary#216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo build --release --lockedas the first step in thecontractsCI job so the job validates the branch binary rather than the last published PyPI wheel--mcp-cmd "./target/release/biomcp serve"instead of relying on the wheel-installedbiomcpcommandmake test-contractsso local and CI contract proofs stay in syncanalysis/technical/overview.mdandRUN.mdto document the current local contract prooftests/test_upstream_planning_analysis_docs.pyto split CI vs release contract expectations, preventing silent regression back to wheel-only validationWhy
The
contractsCI lane was exercising the last published PyPI wheel instead of the branch under review. PRs could pass CI even when CLI or MCP contract changes would have failed once the new binary was shipped. This change closes that verification gap so thecontractsgate reflects actual repo-head behavior.Test plan
make test-contractspasses (cargo build → pytest 53/53 → mkdocs build)uv run pytest tests/test_upstream_planning_analysis_docs.py -vpasses (9/9)contractsjob passes on this PR (validates the new build step runs first)release.ymlvalidate job is unchanged (wheel-based path intentionally preserved)