Skip to content

Add new notification, close #274#275

Merged
Robinlovelace merged 3 commits into
mainfrom
274-leave-review-notification
Apr 11, 2025
Merged

Add new notification, close #274#275
Robinlovelace merged 3 commits into
mainfrom
274-leave-review-notification

Conversation

@Robinlovelace
Copy link
Copy Markdown
Contributor

No description provided.

@Robinlovelace Robinlovelace linked an issue Apr 11, 2025 that may be closed by this pull request
Comment thread helpers/toc.html Outdated
Copy link
Copy Markdown
Member

@Nowosad Nowosad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just keep the previous header of the sidebar. The rest of the changes are great!

@michaeldorman
Copy link
Copy Markdown
Collaborator

Great, thanks!

Co-authored-by: Jakub <Nowosad@users.noreply.github.com>
@Robinlovelace
Copy link
Copy Markdown
Contributor Author

I would just keep the previous header of the sidebar. The rest of the changes are great!

I've accepted your suggestion but am not sure it's better: what's the point of saying it's the "1st edition" if there's only 1 edition (unlike Geocomputation with R)?

@Robinlovelace Robinlovelace merged commit 860b822 into main Apr 11, 2025
2 checks passed
@Robinlovelace Robinlovelace deleted the 274-leave-review-notification branch April 11, 2025 12:17
github-actions Bot pushed a commit that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Leave review' notification

3 participants