Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DCAT formatter improvements #8642

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

josegar74
Copy link
Member

@josegar74 josegar74 commented Feb 6, 2025

  • Improve the functions to obtain record / resource URIs to produce full URIs.
  • The original metadata can be ISO19115.3-2008 or ISO19139. For ISO19139, the extraction of languages was not defined.
  • Use iso2 language code for rdf localised elements.
  • Process all resource constraints.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

…Is to produce full URIs.

Previously rdf:about elements contained not a full URI, like rdf:about='353108a0-f0f8-4f8e-9d0e-60f18dfda169' that was causing validation issues in DCAT-AP validator
@josegar74 josegar74 added this to the 4.4.7 milestone Feb 6, 2025
@josegar74 josegar74 requested a review from fxprunayre February 6, 2025 12:49
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Previously language codes were inconsistent, these type of elements got the language iso3 codes (<dct:title xml:lang='dut'...) and elements from vocabularies, where the language is defined with the iso2 code, got the iso2 code: (<skos:prefLabel xml:lang='nl'...)
Otherwise the template for managing resource constraints in formatter/dcat/dcat-core-access-and-use.xsl did not correctly process the contraints when the first resource constraint had no access or use constraints. For example:

<mri:resourceConstraints>
    <mco:MD_Constraints>
        <mco:useLimitation>
            <gco:CharacterString>Geen gebruiksbeperkingen</gco:CharacterString>
        </mco:useLimitation>
    </mco:MD_Constraints>
</mri:resourceConstraints>
<mri:resourceConstraints>
    <mco:MD_LegalConstraints>
        <mco:accessConstraints>
            <mco:MD_RestrictionCode codeList=http://www.isotc211.org/2005/resources/Codelist/gmxCodelists.xml#MD_RestrictionCode codeListValue=otherRestrictions codeSpace=ISOTC211/19115>otherRestrictions</mco:MD_RestrictionCode>
        </mco:accessConstraints>
        <mco:otherConstraints>
            <gco:CharacterString>Open data (publiek)|https://creativecommons.org/publicdomain/mark/1.0/deed.nl\</gco:CharacterString\>
        </mco:otherConstraints>
    </mco:MD_LegalConstraints>
</mri:resourceConstraints>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants