-
Notifications
You must be signed in to change notification settings - Fork 30
Pywps 4.2.1 implementation #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
modified: docs/conf.py modified: requirements.txt modified: setup.py Bumpped version to 4.2.1
@jorgejesus I personally prefer to use conda environments instead of virtualenv. You can also install |
... building |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a quick check according to the readme. Looks fine :) See my comments inline.
requirements.txt
Outdated
@@ -9,4 +9,4 @@ Shapely | |||
Werkzeug | |||
SQLAlchemy | |||
psutil | |||
-e git+https://github.com/geopython/pywps.git@master#egg=pywps-master | |||
-e git+https://github.com/geopython/pywps.git@4.2.1#egg=pywps-4.2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using pywps form pypi? The requirements list could be shortened ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to pywps package, tested and it is working
README.rst
Outdated
|
||
$ docker run -e GU_WORKERS=10 -e GU_PORT=8082 -p 8082:8082 -it pywps/gunicorn-alpine:latest | ||
|
||
Pywps will be available in the following URL:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"... at the following URL".
There are some more typos in the text.
README.rst
Outdated
|
||
|
||
$ cd docker/ubuntu/nginx/Dockerfile | ||
$ docker build -t pywps/nginx-ubuntu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"." missing in docker build
README.rst
Outdated
This image is based on ``Flask-Ubuntu`` and will require it (either build locally or pull from dockerhub). This image has Nginx and Gunicorn totally integrated as services in a docker image:: | ||
|
||
|
||
$ cd docker/ubuntu/nginx/Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip /Dockerfile
README.rst
Outdated
The same as ``Flask-Ubuntu`` but using phusion image (ubuntu 18.04):: | ||
|
||
|
||
$ cd docker/ubuntu/flask/Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip /Dockerfile
$ docker run -p 5000:5000 pywps/flask-ubuntu | ||
|
||
|
||
Nginx-Ubuntu (production) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter for the demo ... but the docker people prefer "micro-services" like already done in the alpine example (docker-compose to combine nginx+pywps).
Overview
Implementation of pywps 4.2.1 Ticket #49
It implements docker images that were tested with new pywps 4.2.1
Related Issue / Discussion
The current dockerfiles point to the pywps_4.2 branch, this is a sort of chickend and egg problems since docker images point to pywps-flask and from there to the new pywps version
requirements have been change to point to pywps number version tags
Additional Information
If PR is approved it is necessary to path the dockerfiles on master to point to the proper locations.
With PR approval it will be see the automatic build in dockerhub and
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)