Skip to content

fix: replacing --cmd with && in custom build commands #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devLeopar
Copy link

This should resolve #103

here is some more information about this
image

This _generated folder never be created with the --cmd option. This is not a file path issue. I've tried combinations on next build however, the issue is the folder absence. It is replicated locally as well. You can use your CONVEX_DEPLOY_KEY and run that command to see


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thomasballinger
Copy link
Contributor

It sounds like you've got a custom setup where you don't commit the _generated file, generally it's recommended that already exist in version control.

The point of this --cmd is to avoid deploying the convex functions if the frontend build fails:

  1. set .env.local environment variable
  2. run frontend build
  3. if that succeeded, build and deploy convex code.

We could change this a bit for setups like yours that dont' commit _generated by inserting a step between 1 and 2 that runs codegen, but the suggestion in the PR to unconditionally deploy convex functions isn't workable, we don't want to end up deploying new convex functions without deploying a new frontend because the frontend build is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convex deploy problem on nextjs apps
2 participants