feat: add routing hints for private nodes in LND #1186
Conversation
| @@ -492,6 +503,60 @@ func (svc *LNDService) MakeInvoice(ctx context.Context, amount int64, descriptio | |||
| return transaction, nil | |||
| } | |||
|
|
|||
| func (svc *LNDService) getRoutingHints(ctx context.Context) (hints []*lnrpc.RouteHint, err error) { | |||
There was a problem hiding this comment.
Did you take inspiration from anywhere for this code? I think there are quite a few issues here.
Can you please check the LND codebase and some other lightning wallets (e.g. https://github1s.com/ZeusLN/zeus/blob/HEAD/lndmobile/index.ts#L632-L633)
I think there's no limit right now, right? we need to limit it to 3 (the "best" options based on incoming liquidity and fees)
Can you also check if we have 1 peer the route hint is exactly the same as is when not using this code. We need to make very sure we don't break this code otherwise no-one with private channels will be able to receive.
There was a problem hiding this comment.
I'm not sure the above code I linked is used. I've also asked Zeus if they can give us any recommendations.
| continue | ||
| } | ||
|
|
||
| remotePolicy := chanInfo.Node2Policy |
There was a problem hiding this comment.
Node2 is not always the counterparty is it?
Fixes #1171
Goes through all the private channels, if there is a routing policy, it adds that channel as a hint, skips if it doesn't OR if the peer is already processed i.e. added as a hint.