refactor: move crypto logic into go.getarcane.app/sys/crypto#3164
Merged
Conversation
2de0667 to
f865a24
Compare
Contributor
|
Container images for this PR have been built successfully!
Built from commit 955ab2a |
Graphite Automations"Warn authors when publishing large PRs" took an action on this PR • (07/04/26)1 teammate was notified to this PR based on Kyle Mendell's automation. |
f865a24 to
20e6d3a
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can stay up-to-date and reviewed. |
20e6d3a to
955ab2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Checklist
mainbranchm.*())What This PR Implements
Fixes:
Changes Made
Testing Done
AI Tool Used (if applicable)
Additional Context
Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.Greptile Summary
This PR moves backend encryption logic to
go.getarcane.app/sys/crypto. The main changes are:pkg/libarcane/cryptoimports with the shared sys crypto module.ENCRYPTION_KEYpassphrases.Confidence Score: 5/5
This PR appears safe to merge with low risk.
The changes are mostly import rewrites plus removal of the migrated local crypto implementation. The previously reported weak production key regression has been addressed by the new bootstrap guard, and no remaining correctness or security issues were identified in the changed paths.
No files require special attention.
What T-Rex did
Reviews (2): Last reviewed commit: "refactor: move crypto logic into go.geta..." | Re-trigger Greptile