-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(payment_providers): Add MoneyHash #2005
base: main
Are you sure you want to change the base?
Conversation
Hi, can you please allow the CI to run so that I resolve any possible issue? Thanks. CC: @keellyp |
Hey @shahwan42, thanks a lot for your contribution and the time you spent on building this. Please note that to have the CI run correctly we'll have to re-open this PR into our repo. We'll keep you as co-author of the commits of course. It's because we need a private token to run API in our CI and this is not shared (yet) so this is the best workaround we have That being said, can you please make some adjustment on this PR's code about those points?
We're into the process of moving away from styled component and replace it by tailwind all over the app.
We pay extra attention to svg added to our app for many reasons.
I'll keep an eye open to prevent you to wait too long once this is done! |
Hi @ansmonjol Thank you for reviewing this. |
Hey @shahwan42, Sorry for the delay. Looks awesome thanks for updating it. Could you rebase your API code on master? then run the codegen on FE side so we can test it? I would love to have a look at the app running before merging 🙏 |
Thank you, @ansmonjol I've rebased both repos (api&front) and regenerated the GraphQL schema. I'll post demos of my updates to show you how it's expected to work as soon as I can. Side note:
Appreciated. |
Yes this error has been fixed ~1h ago, a rebase should fix your issue |
regenerate graphql schema
Hi @ansmonjol As per your request from last time, here's a demo video of MoneyHash as a payment provider in Lago's system. It's similar to Stripe's video from the official docs. Please view it and LMK if you got any comments or concerns. I appreciate your effort and patience. |
Roadmap Task
NA
Feature Request
https://getlago.canny.io/feature-requests/p/integration-with-moneyhash-for-payment-orchestration
Context
MoneyHash is a leading payment infrastructure software in Africa and the Middle East. Our biggest features are providing a superior payment orchestration for many payment providers in the region, smart payment routing among other features.
We have common customers, and it's a needed feature to have MoneyHash integrated into Lago.
This PR integrates MoneyHash as a payment provider for Lago's customers.
Description
This PR implements the following changes
List any dependencies that are required.
NA