Return empty slice from ListInstallations#3339
Merged
kichristensen merged 2 commits intogetporter:mainfrom Mar 15, 2025
Merged
Conversation
Return an empty slice instead of a `nil` slice if there are no matching installations, so that the json marshaler returns `[]` instead of `null` when outputting json. Signed-off-by: Erik Cederberg <erik.cederberg@sectra.com>
Signed-off-by: Erik Cederberg <erik.cederberg@sectra.com>
erikced
requested review from
bdegeeter,
kichristensen,
schristoff,
sgettys and
troy0820
as code owners
erikced
changed the title
schristoff
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change
Return an empty slice instead of a
nilslice if there are no matching installations, so that the json marshaler returns[]instead ofnull.What issue does it fix
Closes #3338
Checklist