Skip to content

Return empty slice from ListInstallations #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kichristensen merged 2 commits into from
Mar 15, 2025
Merged

Return empty slice from ListInstallations #3339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1009a3
fix(installations): return empty slice instead of nil
erikced Feb 20, 2025
e5b79ee
chore(contributors): update list
erikced Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,4 @@ and we will add you. **All** contributors belong here. 💯
- [Robin Brämer](https://github.com/robinbraemer)
- [Geeta Chavan](https://github.com/geetachavan1)
- [Stephen Augustus](https://github.com/justaugustus)
- [Erik Cederberg](https://github.com/erikced)
2 changes: 1 addition & 1 deletion pkg/porter/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ func (p *Porter) ListInstallations(ctx context.Context, opts ListOptions) (Displ
return nil, log.Error(fmt.Errorf("could not list installations: %w", err))
}

var displayInstallations DisplayInstallations
var displayInstallations DisplayInstallations = DisplayInstallations{}
var fieldSelectorMap map[string]string
if opts.FieldSelector != "" {
fieldSelectorMap, err = parseFieldSelector(opts.FieldSelector)
Expand Down
8 changes: 8 additions & 0 deletions pkg/porter/list_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,14 @@ func TestPorter_ListInstallations(t *testing.T) {
require.NoError(t, err)
assert.Len(t, results, 1)
})

t.Run("empty namespace", func(t *testing.T) {
opts := ListOptions{Namespace: "nonexistent"}
results, err := p.ListInstallations(ctx, opts)
require.NoError(t, err)
assert.Len(t, results, 0)
assert.NotNil(t, results)
})
}

func TestPorter_ListInstallationsWithFieldSelector(t *testing.T) {
Expand Down