Skip to content

Firebase Remote Config Integration #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
Apr 14, 2025
Merged

Firebase Remote Config Integration #2837

merged 36 commits into from
Apr 14, 2025

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Apr 1, 2025

📜 Description

  • Adds sentry_firebase_remote_config package
  • Adds SentryFirebaseRemoteConfigIntegration which tracks feature flags with sentry.

💡 Motivation and Context

Closes #2748

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Check how/when we can release this.

Base automatically changed from feat/feature-flags-integration to main April 7, 2025 12:17
@denrase
Copy link
Collaborator Author

denrase commented Apr 8, 2025

Setup firebase with our sample app and tested the integration. Works as expected. 👍

Bildschirmfoto 2025-04-08 um 10 46 57

@denrase denrase marked this pull request as ready for review April 8, 2025 09:18
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

The only thing that needs clarification is that I'm not sure whether to keep the name sentry_firebase or change it to sentry_firebase_remote_config

I feel like sentry_firebase can be misleading

@kahest wdyt?

@kahest
Copy link
Member

kahest commented Apr 8, 2025

The only thing that needs clarification is that I'm not sure whether to keep the name sentry_firebase or change it to sentry_firebase_remote_config

I feel like sentry_firebase can be misleading

@kahest wdyt?

agree 👍

@kahest kahest requested a review from aliu39 April 8, 2025 11:35
@buenaflor
Copy link
Contributor

then let's change it to firebase_remote_config to be more explicit about the capabilities of the package @denrase

@denrase denrase requested a review from buenaflor April 8, 2025 12:20
@denrase denrase requested a review from buenaflor April 9, 2025 08:29
@denrase denrase requested a review from buenaflor April 9, 2025 14:17
Copy link
Contributor

github-actions bot commented Apr 10, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 462.44 ms 534.55 ms 72.12 ms
Size 6.44 MiB 7.43 MiB 1010.28 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4efee31 308.92 ms 368.68 ms 59.76 ms
90a08ea 477.25 ms 534.10 ms 56.85 ms
bec58b2 478.38 ms 525.02 ms 46.64 ms
2e1e4ae 413.34 ms 509.24 ms 95.90 ms
4f6634c 418.68 ms 524.88 ms 106.20 ms
3751dbc 486.20 ms 538.68 ms 52.48 ms
e3d9076 388.08 ms 488.51 ms 100.43 ms
d089990 361.67 ms 442.50 ms 80.83 ms
f9d18f3 430.94 ms 497.59 ms 66.65 ms
b39b48c 474.21 ms 529.62 ms 55.41 ms

App size

Revision Plain With Sentry Diff
4efee31 5.94 MiB 6.92 MiB 1003.76 KiB
90a08ea 6.49 MiB 7.55 MiB 1.06 MiB
bec58b2 6.49 MiB 7.57 MiB 1.08 MiB
2e1e4ae 6.35 MiB 7.42 MiB 1.06 MiB
4f6634c 6.46 MiB 7.48 MiB 1.02 MiB
3751dbc 6.49 MiB 7.55 MiB 1.06 MiB
e3d9076 6.34 MiB 7.28 MiB 967.79 KiB
d089990 6.34 MiB 7.28 MiB 967.79 KiB
f9d18f3 6.15 MiB 7.13 MiB 1000.49 KiB
b39b48c 6.46 MiB 7.48 MiB 1.02 MiB

Previous results on branch: fear/firebase-feature-flags

Startup times

Revision Plain With Sentry Diff
aa8bcc6 445.41 ms 448.91 ms 3.50 ms
214bd71 471.44 ms 516.20 ms 44.75 ms

App size

Revision Plain With Sentry Diff
aa8bcc6 6.44 MiB 7.43 MiB 1007.37 KiB
214bd71 6.44 MiB 7.43 MiB 1007.62 KiB

Copy link
Contributor

github-actions bot commented Apr 10, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1267.49 ms 1274.17 ms 6.68 ms
Size 8.43 MiB 10.00 MiB 1.57 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ddc97ad 1228.02 ms 1232.61 ms 4.59 ms
178baee 1230.61 ms 1249.94 ms 19.33 ms
e442847 1245.96 ms 1266.59 ms 20.63 ms
b728df4 1287.43 ms 1293.94 ms 6.51 ms
81bb164 1243.42 ms 1277.22 ms 33.81 ms
ffae3e3 1215.82 ms 1238.49 ms 22.67 ms
0ceb89c 1252.02 ms 1271.78 ms 19.75 ms
231f523 1257.51 ms 1280.23 ms 22.72 ms
6a40d32 1253.50 ms 1266.49 ms 12.99 ms
754cdbe 1261.67 ms 1280.88 ms 19.20 ms

App size

Revision Plain With Sentry Diff
ddc97ad 8.29 MiB 9.37 MiB 1.08 MiB
178baee 8.34 MiB 9.67 MiB 1.33 MiB
e442847 8.42 MiB 9.86 MiB 1.44 MiB
b728df4 8.15 MiB 9.15 MiB 1020.72 KiB
81bb164 8.38 MiB 9.77 MiB 1.40 MiB
ffae3e3 8.28 MiB 9.33 MiB 1.05 MiB
0ceb89c 8.15 MiB 9.12 MiB 989.78 KiB
231f523 8.43 MiB 9.97 MiB 1.54 MiB
6a40d32 8.29 MiB 9.37 MiB 1.08 MiB
754cdbe 8.29 MiB 9.37 MiB 1.08 MiB

Previous results on branch: fear/firebase-feature-flags

Startup times

Revision Plain With Sentry Diff
214bd71 1241.25 ms 1267.04 ms 25.79 ms
aa8bcc6 1255.92 ms 1262.06 ms 6.14 ms

App size

Revision Plain With Sentry Diff
214bd71 8.43 MiB 9.99 MiB 1.56 MiB
aa8bcc6 8.43 MiB 9.99 MiB 1.56 MiB

@denrase denrase merged commit b356fb0 into main Apr 14, 2025
15 of 16 checks passed
@denrase denrase deleted the fear/firebase-feature-flags branch April 14, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flutter] Feature Flags Reporting - Firebase Remote Config integration
3 participants