-
-
Notifications
You must be signed in to change notification settings - Fork 251
Firebase Remote Config Integration #2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
The only thing that needs clarification is that I'm not sure whether to keep the name sentry_firebase
or change it to sentry_firebase_remote_config
I feel like sentry_firebase
can be misleading
@kahest wdyt?
agree 👍 |
then let's change it to firebase_remote_config to be more explicit about the capabilities of the package @denrase |
firebase/lib/src/sentry_firebase_remote_config_integration.dart
Outdated
Show resolved
Hide resolved
firebase_remote_config/lib/src/sentry_firebase_remote_config_integration.dart
Show resolved
Hide resolved
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4efee31 | 308.92 ms | 368.68 ms | 59.76 ms |
90a08ea | 477.25 ms | 534.10 ms | 56.85 ms |
bec58b2 | 478.38 ms | 525.02 ms | 46.64 ms |
2e1e4ae | 413.34 ms | 509.24 ms | 95.90 ms |
4f6634c | 418.68 ms | 524.88 ms | 106.20 ms |
3751dbc | 486.20 ms | 538.68 ms | 52.48 ms |
e3d9076 | 388.08 ms | 488.51 ms | 100.43 ms |
d089990 | 361.67 ms | 442.50 ms | 80.83 ms |
f9d18f3 | 430.94 ms | 497.59 ms | 66.65 ms |
b39b48c | 474.21 ms | 529.62 ms | 55.41 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4efee31 | 5.94 MiB | 6.92 MiB | 1003.76 KiB |
90a08ea | 6.49 MiB | 7.55 MiB | 1.06 MiB |
bec58b2 | 6.49 MiB | 7.57 MiB | 1.08 MiB |
2e1e4ae | 6.35 MiB | 7.42 MiB | 1.06 MiB |
4f6634c | 6.46 MiB | 7.48 MiB | 1.02 MiB |
3751dbc | 6.49 MiB | 7.55 MiB | 1.06 MiB |
e3d9076 | 6.34 MiB | 7.28 MiB | 967.79 KiB |
d089990 | 6.34 MiB | 7.28 MiB | 967.79 KiB |
f9d18f3 | 6.15 MiB | 7.13 MiB | 1000.49 KiB |
b39b48c | 6.46 MiB | 7.48 MiB | 1.02 MiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ddc97ad | 1228.02 ms | 1232.61 ms | 4.59 ms |
178baee | 1230.61 ms | 1249.94 ms | 19.33 ms |
e442847 | 1245.96 ms | 1266.59 ms | 20.63 ms |
b728df4 | 1287.43 ms | 1293.94 ms | 6.51 ms |
81bb164 | 1243.42 ms | 1277.22 ms | 33.81 ms |
ffae3e3 | 1215.82 ms | 1238.49 ms | 22.67 ms |
0ceb89c | 1252.02 ms | 1271.78 ms | 19.75 ms |
231f523 | 1257.51 ms | 1280.23 ms | 22.72 ms |
6a40d32 | 1253.50 ms | 1266.49 ms | 12.99 ms |
754cdbe | 1261.67 ms | 1280.88 ms | 19.20 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ddc97ad | 8.29 MiB | 9.37 MiB | 1.08 MiB |
178baee | 8.34 MiB | 9.67 MiB | 1.33 MiB |
e442847 | 8.42 MiB | 9.86 MiB | 1.44 MiB |
b728df4 | 8.15 MiB | 9.15 MiB | 1020.72 KiB |
81bb164 | 8.38 MiB | 9.77 MiB | 1.40 MiB |
ffae3e3 | 8.28 MiB | 9.33 MiB | 1.05 MiB |
0ceb89c | 8.15 MiB | 9.12 MiB | 989.78 KiB |
231f523 | 8.43 MiB | 9.97 MiB | 1.54 MiB |
6a40d32 | 8.29 MiB | 9.37 MiB | 1.08 MiB |
754cdbe | 8.29 MiB | 9.37 MiB | 1.08 MiB |
📜 Description
sentry_firebase_remote_config
packageSentryFirebaseRemoteConfigIntegration
which tracks feature flags with sentry.💡 Motivation and Context
Closes #2748
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
Check how/when we can release this.