-
-
Notifications
You must be signed in to change notification settings - Fork 251
fix: options.diagnosticLevel
not affecting logs
#2856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* update * update test * update init native sdk test * Update CHANGELOG * Add additional test
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## temp/8.14.2 #2856 +/- ##
============================================
Coverage 88.91% 88.92%
============================================
Files 263 263
Lines 8951 8955 +4
============================================
+ Hits 7959 7963 +4
Misses 992 992 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only questiion is why we have an unrelated prod.xcscheme
added here?
ah thanks, that should not be part of the PR , I'll remove it |
Note: this will be merged in v8
Fixes user not being able to set the log level
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps