Skip to content

fix: options.diagnosticLevel not affecting logs #2856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 15, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Apr 11, 2025

Note: this will be merged in v8

Fixes user not being able to set the log level

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

buenaflor and others added 4 commits April 11, 2025 14:31
* update

* update test

* update init native sdk test

* Update CHANGELOG

* Add additional test
Copy link
Contributor

github-actions bot commented Apr 11, 2025

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • flutter/lib/src/screenshot/recorder.dart

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (f502e51) to head (a3dfaa0).
Report is 1 commits behind head on temp/8.14.2.

Additional details and impacted files
@@             Coverage Diff              @@
##           temp/8.14.2    #2856   +/-   ##
============================================
  Coverage        88.91%   88.92%           
============================================
  Files              263      263           
  Lines             8951     8955    +4     
============================================
+ Hits              7959     7963    +4     
  Misses             992      992           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buenaflor buenaflor marked this pull request as ready for review April 14, 2025 12:07
@buenaflor buenaflor requested a review from denrase April 14, 2025 12:14
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only questiion is why we have an unrelated prod.xcscheme added here?

@buenaflor
Copy link
Contributor Author

ah thanks, that should not be part of the PR , I'll remove it

@buenaflor buenaflor merged commit 2a30a8a into temp/8.14.2 Apr 15, 2025
159 of 160 checks passed
@buenaflor buenaflor deleted the fix/diagnosticLevel branch April 15, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants