Skip to content

Conversation

buenaflor
Copy link
Contributor

📜 Description

Reuse the new isolate worker class

💡 Motivation and Context

Uses the common worker class which was introduced in #3232

💚 How did you test it?

Manual test

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

🚨 Detected changes in high risk code 🚨

High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:

  • packages/flutter/lib/src/native/java/android_replay_recorder.dart

Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.85%. Comparing base (a10aff4) to head (b9de973).

Files with missing lines Patch % Lines
...r/lib/src/native/java/android_replay_recorder.dart 0.00% 33 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3296      +/-   ##
==========================================
+ Coverage   87.82%   89.85%   +2.03%     
==========================================
  Files         294       99     -195     
  Lines       10143     3509    -6634     
==========================================
- Hits         8908     3153    -5755     
+ Misses       1235      356     -879     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1279.75 ms 1276.15 ms -3.60 ms
Size 5.53 MiB 6.01 MiB 487.29 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
192b44c 1269.08 ms 1275.52 ms 6.44 ms
c1e775e 1263.08 ms 1275.32 ms 12.24 ms
79f6b41 1269.33 ms 1279.71 ms 10.38 ms
eca355d 1238.39 ms 1266.98 ms 28.59 ms
de377fd 1252.28 ms 1254.76 ms 2.48 ms
c8596a6 1234.11 ms 1241.19 ms 7.08 ms
e2d675d 1238.48 ms 1242.76 ms 4.28 ms
793f4dc 1262.50 ms 1282.35 ms 19.85 ms
81f83eb 1259.53 ms 1273.39 ms 13.86 ms
4481076 1256.48 ms 1266.64 ms 10.17 ms

App size

Revision Plain With Sentry Diff
192b44c 5.53 MiB 5.96 MiB 444.33 KiB
c1e775e 20.70 MiB 22.46 MiB 1.75 MiB
79f6b41 7.86 MiB 9.44 MiB 1.58 MiB
eca355d 7.86 MiB 9.44 MiB 1.58 MiB
de377fd 20.71 MiB 22.43 MiB 1.73 MiB
c8596a6 7.86 MiB 9.44 MiB 1.58 MiB
e2d675d 7.86 MiB 9.44 MiB 1.58 MiB
793f4dc 7.86 MiB 9.44 MiB 1.58 MiB
81f83eb 7.86 MiB 9.44 MiB 1.58 MiB
4481076 7.86 MiB 9.44 MiB 1.58 MiB

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 475.33 ms 506.29 ms 30.95 ms
Size 13.93 MiB 15.06 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0fb3800 465.64 ms 536.77 ms 71.13 ms
81f83eb 471.40 ms 522.14 ms 50.74 ms
93b7728 475.28 ms 489.13 ms 13.86 ms
e04b24b 504.72 ms 516.43 ms 11.71 ms
2d34233 470.54 ms 558.90 ms 88.36 ms
640ad0c 466.00 ms 552.67 ms 86.67 ms
4298701 524.40 ms 633.30 ms 108.90 ms
7cfee3b 498.78 ms 516.98 ms 18.20 ms
4481076 484.08 ms 505.70 ms 21.61 ms
54acf91 487.24 ms 529.60 ms 42.36 ms

App size

Revision Plain With Sentry Diff
0fb3800 6.54 MiB 7.69 MiB 1.15 MiB
81f83eb 6.54 MiB 7.69 MiB 1.15 MiB
93b7728 6.54 MiB 7.69 MiB 1.15 MiB
e04b24b 13.93 MiB 15.00 MiB 1.06 MiB
2d34233 6.54 MiB 7.55 MiB 1.01 MiB
640ad0c 6.54 MiB 7.69 MiB 1.15 MiB
4298701 6.54 MiB 7.71 MiB 1.17 MiB
7cfee3b 6.54 MiB 7.70 MiB 1.17 MiB
4481076 6.54 MiB 7.69 MiB 1.15 MiB
54acf91 6.54 MiB 7.70 MiB 1.17 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant