Skip to content

fix: Fix replay privacy code example #11244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 5, 2024

Closes #11090

Our old snippet had some typos in it. Now, the JS example should be fine.
Because the example does not work well in TS, for this case I opted to also add a TS example too.

@mydea mydea requested a review from billyvg September 5, 2024 14:35
@mydea mydea self-assigned this Sep 5, 2024
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 7:53am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 7:53am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 6, 2024 7:53am

Copy link

codecov bot commented Sep 5, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.44MB 6 bytes ⬇️
sentry-docs-edge-server 254.5kB 3 bytes ⬇️
sentry-docs-client 6.39MB 6 bytes ⬇️

@@ -130,25 +130,51 @@ To scrub the URL in a recording event, use the above `beforeAddRecordingEvent`.
To scrub the URL in a replay event, use `addEventProcessor`:

```javascript
Sentry.addEventProcessor(event) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@mydea mydea merged commit 480d5b3 into master Sep 6, 2024
10 checks passed
@mydea mydea deleted the fn/replay-privacy-example branch September 6, 2024 08:13
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Scrubbing URLs" Example code will not pass type check
2 participants