Skip to content

ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK #12801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 21, 2025

To be merged after 9.2.0 was released

This PR updates our Cloudflare and SvelteKit guides now that the SvelteKit SDK supports cloudflare directly (getsentry/sentry-javascript#14672).

  • Adjust Cloudflare for SvelteKit guide by removing the @sentry/cloudflare references and showing how to init the SDK with the newly added request handler
  • Adjust the Sveltekit SDK's compatibility note
  • Link to cloudflare guide from manual setup for SvelteKit

I decided against making a versioned doc of the Cloudflare SvelteKit framework guide as AFAICT the previous setup instructions didn't work correctly and caused production build errors.

Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2025 9:28am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2025 9:28am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2025 9:28am

@Lms24 Lms24 self-assigned this Feb 21, 2025
Copy link

codecov bot commented Feb 21, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.94MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/6Lv4UY_5En1fKEOxTtxl-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/6Lv4UY_5En1fKEOxTtxl-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/jMuvAtWI2aO9eNjZ-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/jMuvAtWI2aO9eNjZ-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%

@Lms24 Lms24 requested a review from AbhiPrasad February 21, 2025 13:20
@Lms24 Lms24 changed the title ref(sveltekit): Adjust cloudflare setup to only use SvelteKit SDK ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK Feb 21, 2025
Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@Lms24 Lms24 merged commit 0c9278e into master Feb 26, 2025
11 checks passed
@Lms24 Lms24 deleted the lms/ref-sveltekit-adjust-cloudflare-setup branch February 26, 2025 22:00
codyde added a commit that referenced this pull request Feb 27, 2025
* master: (45 commits)
  feat: Mention that the cookie-sync extension works for previews (#12858)
  ref(flags): update unleashIntegration param (#12795)
  ref(sveltekit): Adjust Cloudflare setup to only use SvelteKit SDK (#12801)
  docs(python): Clarify how to init SDK in `async` app (#12854)
  move content about error capturing to "Capturing Errors and Events" from "Manual Setup" (Next.js) (#12786)
  docs(span-links): Add develop docs for span links (#12829)
  feat(java): add Reactor integration docs (#12686)
  Add Quarkus to community maintained SDKs (#12834)
  Adding unsupported hot reload (#12683)
  Fix broken links (#12844)
  feat(python): Clarification regarding start_transaction (#12835)
  docs(flutter): Fix event serverName reset in samples (#12832)
  ref(insights): move performance docs under insights (#12720)
  Bump API schema to 2e61347a (#12836)
  fix(apple): Usages of sendDefaultPii (#12833)
  Add `sendDefaultPii: true` to React Native init code snippets (#12812)
  Only show Browser vs React Native source maps alert for browser sdks (#12816)
  Add Data Collected page for React Native (#12811)
  Fix React Native Onboarding Option Buttons (#12813)
  Add Hono guide (#12710)
  ...
limbonaut pushed a commit that referenced this pull request Feb 28, 2025
…2801)

* ref(sveltekit): Adjust cloudflare setup to only use SvelteKit SDK

* more linking, rewording

* Apply suggestions from code review

Co-authored-by: Alex Krawiec <[email protected]>

---------

Co-authored-by: Alex Krawiec <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants