Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(develop): Add outgoing_request context #13204

Draft
wants to merge 4 commits into
base: fn/page-context
Choose a base branch
from

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 2, 2025

This should replace event.request on the client completely.

Draft on top of #13203

@mydea mydea self-assigned this Apr 2, 2025
Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2025 2:41pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 2:41pm
sentry-docs ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 2:41pm

{
"contexts": {
"outgoing_request": {
"url": "https://sentry.io/api/0/projects/sentry/sentry/issues/?page=1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I based this on https://develop.sentry.dev/sdk/data-model/event-payloads/request/#attributes:

url Optional. The URL of the request if available. The query string can be
declared either as part of the url, or separately in query_string.

We can split it out for sure!

@bruno-garcia
Copy link
Member

bruno-garcia commented Apr 2, 2025

This should replace event.request on the client completely.

if the product will have UX based in the new outgoing request field (which makes sense) could we have something in Relay that moves event.request to the new field when we know it's a client event? the heuristics to be defined (sdk name? other fields etc)

this way older sdks can have the benefits added by the new field

@mydea
Copy link
Member Author

mydea commented Apr 2, 2025

This should replace event.request on the client completely.

if the product will have UX based in the new outgoing request field (which makes sense) could we have something in Relay that moves event.request to the new field when we know it's a client event? the heuristics to be defined (sdk name? other fields etc)

this way older sdks can have the benefits added by the new field

The idea is that today we have this overloaded thing - you can't even really set this outgoing_request information as of now for server SDKs, because event.request is already used for the incoming request information. So I do not think it will really be possible to extract this, as we can't easily differentiate what kind of data is stored in event.request 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants