-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(develop): Add outgoing_request
context
#13204
base: fn/page-context
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
{ | ||
"contexts": { | ||
"outgoing_request": { | ||
"url": "https://sentry.io/api/0/projects/sentry/sentry/issues/?page=1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not store query parameters this way. https://develop.sentry.dev/sdk/expected-features/data-handling/#spans
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I based this on https://develop.sentry.dev/sdk/data-model/event-payloads/request/#attributes:
url
Optional. The URL of the request if available. The query string can be
declared either as part of the url, or separately in query_string.
We can split it out for sure!
if the product will have UX based in the new outgoing request field (which makes sense) could we have something in Relay that moves event.request to the new field when we know it's a client event? the heuristics to be defined (sdk name? other fields etc) this way older sdks can have the benefits added by the new field |
The idea is that today we have this overloaded thing - you can't even really set this outgoing_request information as of now for server SDKs, because |
This should replace `event.request` on the client completely.
2ede4a0
to
8d37afa
Compare
This should replace
event.request
on the client completely.Draft on top of #13203