-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
RN: Adds feedback button doc #13512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
RN: Adds feedback button doc #13512
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
I'm not seeing anywhere in the react-native SDKs where we reference |
Thank you for looking at this @sfanahata 🙇
The implementation is still on the feature branch and the docs PRs should be merged after getsentry/sentry-react-native#4726 is released. |
docs/platforms/react-native/user-feedback/configuration/index.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: LucasZF <[email protected]>
docs/platforms/react-native/user-feedback/configuration/index.mdx
Outdated
Show resolved
Hide resolved
Overall the PR looks good! We can approve it once a new release with the given features mentioned here are released. |
Co-authored-by: LucasZF <[email protected]>
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
Adds feedback button documentation.
Part of getsentry/sentry-react-native#4302
Implementation PR: getsentry/sentry-react-native#4378
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Should be merged after getsentry/sentry-react-native#4726 is released
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES