Skip to content

feat(platform): Set sentry.source to custom for edge requests #13755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

chargome
Copy link
Member

This is a temporary change to evaluate effects on grouping in Sentry.

@chargome chargome self-assigned this May 19, 2025
Copy link

vercel bot commented May 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 2:57pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 2:57pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) May 19, 2025 2:57pm

@chargome chargome requested a review from cleptric May 19, 2025 14:44
Copy link

codecov bot commented May 19, 2025

Bundle Report

Changes will increase total bundle size by 158 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.2MB -9 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 377.18kB 173 bytes (0.05%) ⬆️
sentry-docs-client-array-push 9.51MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%

Files in ../instrumentation.js:

  • ./src/instrumentation.ts → Total Size: 1.51kB
view changes for bundle: sentry-docs-edge-server-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
edge-instrumentation.js 173 bytes 162.83kB 0.11%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
server/middleware-*.js -5.55kB 1.0kB -84.74%
static/P9HiWWfa5VzVTe7NDDjSm/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/P9HiWWfa5VzVTe7NDDjSm/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/RhlzctAoFjw9MF3ZNgxBk/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/RhlzctAoFjw9MF3ZNgxBk/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@dcramer
Copy link
Member

dcramer commented May 19, 2025

Can we not resort to things like this? Customers have to maintain the mental burden of this kind of change, when all we need to do is fix the server side

@dcramer
Copy link
Member

dcramer commented May 19, 2025

Sorry ignore my comment - realized this is just internal to docs

@chargome chargome merged commit dd7a7c5 into master May 20, 2025
15 checks passed
@chargome chargome deleted the cg-custom-tx branch May 20, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants