Skip to content

Add Android new User Feedback instructions #13758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

stefanosiano
Copy link
Member

DESCRIBE YOUR PR

added new User Feedback API instructions
added new User Feedback Widget configuration options

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

added new User Feedback Widget configuration options
Copy link

vercel bot commented May 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2025 10:18am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview May 20, 2025 10:18am
develop-docs ⬜️ Ignored (Inspect) Visit Preview May 20, 2025 10:18am

@stefanosiano stefanosiano requested a review from kahest May 19, 2025 17:13
@codeowner-assignment codeowner-assignment bot requested a review from a team May 19, 2025 17:13
Copy link

codecov bot commented May 19, 2025

Bundle Report

Changes will increase total bundle size by 210 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.2MB 216 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.51MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 75 bytes 396.71kB 0.02%
../app/platform-redirect/page.js.nft.json 75 bytes 396.63kB 0.02%
../app/sitemap.xml/route.js.nft.json 75 bytes 394.6kB 0.02%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.7kB -0.0%
static/chunks/8165-*.js -3 bytes 410.1kB -0.0%
static/mIkFVHuvvfFjgz3-*.js (New) 578 bytes 578 bytes 100.0% 🚀
static/mIkFVHuvvfFjgz3-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/-*.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

### Form Labels Configuration

You can customize tha labels and placeholders used in the form.
Note: manifest options are not supported here, due to internationalization:
Copy link
Contributor

@buenaflor buenaflor May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe the note should be an <Alert>, up to you

@stefanosiano stefanosiano requested review from markushi and romtsn May 20, 2025 09:57
Comment on lines +15 to +20
| Hook | Type | Description |
| ----------------- | ------------------------- | ------------------------------------------------------------------------ |
| `onFormOpen` | `() -> Void` | Called when the feedback form is opened. |
| `onFormClose` | `() -> Void` | Called when the feedback form is closed. |
| `onSubmitSuccess` | `(Feedback) -> Void` | Called when feedback is successfully submitted via the prepared form. |
| `onSubmitError` | `(Feedback) -> Void` | Called when there is an error submitting feedback via the prepared form. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the tables 👍

we should use those more often in docs where it makes sense 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants