-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(js): Import BrowserTracing
directly from a browser SDK
#6508
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few suggestions.
src/platforms/javascript/common/configuration/tree-shaking/index.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/configure-sample-rate/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/configure-sample-rate/javascript.react.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/configure-sample-rate/javascript.vue.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/common/configuration/webworkers/index.mdx
Outdated
Show resolved
Hide resolved
src/platforms/javascript/guides/ember/configuration/ember-options.mdx
Outdated
Show resolved
Hide resolved
Plan is now to merge this in next week! |
I found these changes too but didn't put them in my PR because they're browser related. 3 of the 4 file changes are simply replacing However there was also a |
src/platform-includes/performance/automatic-instrumentation-intro/javascript.mdx
Outdated
Show resolved
Hide resolved
src/platform-includes/performance/configure-sample-rate/javascript.mdx
Outdated
Show resolved
Hide resolved
36422e0
to
6e3f32f
Compare
Co-authored-by: Liza Mock <[email protected]>
Co-authored-by: Lukas Stracke <[email protected]>
6e3f32f
to
37cdc3c
Compare
Sorry for the ping folks - had a busted git merge that I needed to repair. |
ref getsentry/sentry-javascript#5815
Docs for changes in getsentry/sentry-javascript#7342 that was just released with
7.44.0
.This PR updates our instructions to remove the dependency on using the
@sentry/tracing
package for the frontend JS SDKs. Instead users can now just importBrowserTracing
directly from a package.Basically from:
to