Skip to content

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Oct 14, 2025

📜 Description

  • Add new ctor overloads that accept a handler to deliver the callbacks of the integrations on
  • Additionally deduplicate SystemEventsIntegration and favour the user-added ones

💡 Motivation and Context

Part of getsentry/sentry-dotnet#3828
Closes #4700

💚 How did you test it?

Automated

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@romtsn
Copy link
Member Author

romtsn commented Oct 14, 2025

cc @jpnurmi @jamescrosswell

Copy link
Contributor

github-actions bot commented Oct 14, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 52f7632

Copy link
Contributor

github-actions bot commented Oct 14, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 394.18 ms 463.98 ms 69.80 ms
Size 1.58 MiB 2.11 MiB 539.75 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
23d6b12 354.10 ms 408.38 ms 54.28 ms
9fbb112 361.43 ms 427.57 ms 66.14 ms
1df7eb6 397.04 ms 429.64 ms 32.60 ms
c8125f3 397.65 ms 485.14 ms 87.49 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms
b750b96 408.98 ms 480.32 ms 71.34 ms
f634d01 359.58 ms 433.88 ms 74.30 ms
806307f 357.85 ms 424.64 ms 66.79 ms
ee747ae 374.71 ms 455.18 ms 80.47 ms
ce0a49e 532.00 ms 609.96 ms 77.96 ms

App size

Revision Plain With Sentry Diff
23d6b12 1.58 MiB 2.10 MiB 532.31 KiB
9fbb112 1.58 MiB 2.11 MiB 539.18 KiB
1df7eb6 1.58 MiB 2.10 MiB 532.97 KiB
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
b750b96 1.58 MiB 2.10 MiB 533.19 KiB
f634d01 1.58 MiB 2.10 MiB 533.40 KiB
806307f 1.58 MiB 2.10 MiB 533.42 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ce0a49e 1.58 MiB 2.10 MiB 532.94 KiB

Previous results on branch: rz/feat/system-network-integrations-overloads

Startup times

Revision Plain With Sentry Diff
0f5d616 391.26 ms 473.94 ms 82.68 ms

App size

Revision Plain With Sentry Diff
0f5d616 1.58 MiB 2.11 MiB 539.75 KiB

@jpnurmi
Copy link

jpnurmi commented Oct 14, 2025

Hi @romtsn, this is amazing - thanks so much!

I can confirm that both network and battery breadcrumbs are delivered in the main thread with this. 👍

https://github.com/getsentry/sentry-dotnet/blob/cdcde69631cba997b0261ef8de2f92ea3b46d6e7/src/Sentry/Platforms/Android/SentrySdk.cs#L161-L169

@romtsn
Copy link
Member Author

romtsn commented Oct 14, 2025

@jpnurmi great, thanks for trying out! I will wait for the maintainers' review and then merge and ship it soon

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@romtsn romtsn enabled auto-merge (squash) October 16, 2025 09:31
@romtsn romtsn merged commit 889ecea into main Oct 16, 2025
61 checks passed
@romtsn romtsn deleted the rz/feat/system-network-integrations-overloads branch October 16, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network breadcrumbs are delivered in a background thread

3 participants