fix(core): Don't crash on recoverable CLI command error #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Mar 4, 2025
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 5, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.2.0 | 3.2.2 | ## [v3.2.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#322) - feat(annotation): Handle JSX member expressions ([#690](getsentry/sentry-javascript-bundler-plugins#690)) - fix(core): Don't crash on recoverable CLI command error ([#682](getsentry/sentry-javascript-bundler-plugins#682)) - chore: Suggest putting `SENTRY_AUTH_TOKEN`, `SENTRY_ORG` and `SENTRY_PROJECT` in `passThroughEnv` when using Turborepo ([#675](getsentry/sentry-javascript-bundler-plugins#675)) ## [v3.2.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#321) - deps: Bump [@sentry/cli](https://github.com/sentry/cli) to 2.42.2 ([#685](getsentry/sentry-javascript-bundler-plugins#685))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 8, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.2.0 | 3.2.2 | ## [v3.2.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#322) - feat(annotation): Handle JSX member expressions ([#690](getsentry/sentry-javascript-bundler-plugins#690)) - fix(core): Don't crash on recoverable CLI command error ([#682](getsentry/sentry-javascript-bundler-plugins#682)) - chore: Suggest putting `SENTRY_AUTH_TOKEN`, `SENTRY_ORG` and `SENTRY_PROJECT` in `passThroughEnv` when using Turborepo ([#675](getsentry/sentry-javascript-bundler-plugins#675)) ## [v3.2.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#321) - deps: Bump [@sentry/cli](https://github.com/sentry/cli) to 2.42.2 ([#685](getsentry/sentry-javascript-bundler-plugins#685))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 9, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.2.0 | 3.2.2 | ## [v3.2.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#322) - feat(annotation): Handle JSX member expressions ([#690](getsentry/sentry-javascript-bundler-plugins#690)) - fix(core): Don't crash on recoverable CLI command error ([#682](getsentry/sentry-javascript-bundler-plugins#682)) - chore: Suggest putting `SENTRY_AUTH_TOKEN`, `SENTRY_ORG` and `SENTRY_PROJECT` in `passThroughEnv` when using Turborepo ([#675](getsentry/sentry-javascript-bundler-plugins#675)) ## [v3.2.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#321) - deps: Bump [@sentry/cli](https://github.com/sentry/cli) to 2.42.2 ([#685](getsentry/sentry-javascript-bundler-plugins#685))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 11, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.2.0 | 3.2.2 | ## [v3.2.2](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#322) - feat(annotation): Handle JSX member expressions ([#690](getsentry/sentry-javascript-bundler-plugins#690)) - fix(core): Don't crash on recoverable CLI command error ([#682](getsentry/sentry-javascript-bundler-plugins#682)) - chore: Suggest putting `SENTRY_AUTH_TOKEN`, `SENTRY_ORG` and `SENTRY_PROJECT` in `passThroughEnv` when using Turborepo ([#675](getsentry/sentry-javascript-bundler-plugins#675)) ## [v3.2.1](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#321) - deps: Bump [@sentry/cli](https://github.com/sentry/cli) to 2.42.2 ([#685](getsentry/sentry-javascript-bundler-plugins#685))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes our error handling logic to no longer throw if:
We still throw an error if
Worth noting that all of this is default behaviour. If users pass a custom errorHandler to their plugin config, they still have full control over throwing or swallowing the error.
closes #681