Skip to content

Vendor @fastify/otel instrumentation #16309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andreiborza opened this issue May 15, 2025 — with Linear · 1 comment · Fixed by #16328
Closed

Vendor @fastify/otel instrumentation #16309

andreiborza opened this issue May 15, 2025 — with Linear · 1 comment · Fixed by #16328
Assignees
Labels
javascript Pull requests that update javascript code

Comments

Copy link
Member

andreiborza commented May 15, 2025

Description

We forked @fastify/otel before to downgrade its OpenTelemetry dependencies to v1 to match those of our SDKs. This came with issues on its own: #16281, #16300

Both pnpm and yarn v3 have issues with the way we specify the url to the fork, therefore we should switch strategy and vendor the instrumentation in.

Related to #16311

@andreiborza andreiborza added the javascript Pull requests that update javascript code label May 15, 2025 — with Linear
andreiborza pushed a commit that referenced this issue May 20, 2025
Resolves: #16309 

I tried to make as few modifications as possible for easier updates from
the original implementation in the future.

- Converted `require`s and `module.export`s to `import`s and `exports`
- Created a local `eslint` configuration
- Hard-coded `name` and `version` to the vendored version instead of
reading from `package.json`
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #16328, which was included in the 9.21.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants