-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(node): Vendor in @fastify/otel
#16328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall, what issues were you running into with the logger and TS?
The original implementation was assigning the |
e4054b0
to
cee8d3d
Compare
size-limit report 📦
|
88352b5
to
585555f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of this @onurtemizkan
585555f
to
0a4e6de
Compare
Resolves: #16309
I tried to make as few modifications as possible for easier updates from the original implementation in the future.
require
s andmodule.export
s toimport
s andexports
eslint
configurationname
andversion
to the vendored version instead of reading frompackage.json