Skip to content

docs: Fix paths in readme to point to proper files #11364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 2, 2024

This was noticed here: #11337 (comment), when viewed on e.g. npmjs.org the relative links to do not work, so we should have full URLs only in the readme files.

It would be nicer if we could replace this with a proper full URL at release time to point to the correct version of the file, but that's more work and probably not worth it...

@mydea mydea requested review from lforst, Lms24 and s1gr1d April 2, 2024 10:24
@mydea mydea self-assigned this Apr 2, 2024
@mydea mydea merged commit 5d98a4c into develop Apr 2, 2024
29 checks passed
@mydea mydea deleted the fn/fix-readme-link branch April 2, 2024 10:55
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
This was noticed here:
getsentry#11337 (comment),
when viewed on e.g. npmjs.org the relative links to do not work, so we
should have full URLs only in the readme files.

It would be _nicer_ if we could replace this with a proper full URL at
release time to point to the correct version of the file, but that's
more work and probably not worth it...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants