perf(node): Truncate breadcrumb messages created by console integration #14006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
reviewed
Oct 17, 2024
| @@ -14,11 +17,17 @@ const _consoleIntegration = (() => { | |||
| return; | |||
| } | |||
|
|
|||
| // Truncate the breadcrumb length to max 2KB including the truncated snippet | |||
| let formattedMessage: string = util.format.apply(undefined, args); | |||
| if (formattedMessage.length > MAX_BREADCRUMB_MSG_LENGTH) { | |||
There was a problem hiding this comment.
l: Why not just use truncate from @sentry/utils? :)
There was a problem hiding this comment.
I did not know that existed 🧠 nice
Lms24
reviewed
Oct 18, 2024
Fuck it, I'll be a good person for once and add tests 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a report that the SDK was consuming a lot of memory. Looking at the heap snapshot I noticed that we are unboundidly storing strings in breadcrumbs, no matter how large they are, leading to the breadcrumbs potentially holding a lot of memory.