Skip to content

feat(core): Hoist everything from @sentry/utils into @sentry/core #14382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Nov 20, 2024

Ref #14269

This PR hoists the entirety of @sentry/utils into @sentry/core. Currently, nothing is deprecated. That will happen in a followup and after we have updated docs to not reference @sentry/utils.

In theory, this should not change any functionality whatsoever

Copy link
Contributor

github-actions bot commented Nov 20, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.86 KB +0.25% +58 B 🔺
@sentry/browser - with treeshaking flags 21.57 KB -0.02% -4 B 🔽
@sentry/browser (incl. Tracing) 35.41 KB +0.27% +95 B 🔺
@sentry/browser (incl. Tracing, Replay) 72.09 KB +0.06% +37 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.41 KB -0.02% -12 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 76.39 KB +0.06% +42 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 88.87 KB +0.09% +78 B 🔺
@sentry/browser (incl. Feedback) 39.6 KB +0.1% +40 B 🔺
@sentry/browser (incl. sendFeedback) 27.5 KB +0.18% +48 B 🔺
@sentry/browser (incl. FeedbackAsync) 32.3 KB +0.1% +31 B 🔺
@sentry/react 25.56 KB -0.05% -11 B 🔽
@sentry/react (incl. Tracing) 38.27 KB +0.02% +6 B 🔺
@sentry/vue 27.02 KB +0.25% +68 B 🔺
@sentry/vue (incl. Tracing) 37.23 KB +0.23% +84 B 🔺
@sentry/svelte 23.01 KB +0.29% +68 B 🔺
CDN Bundle 24.04 KB -0.51% -126 B 🔽
CDN Bundle (incl. Tracing) 36.99 KB -0.33% -124 B 🔽
CDN Bundle (incl. Tracing, Replay) 71.69 KB -0.12% -84 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 77.05 KB -0.1% -74 B 🔽
CDN Bundle - uncompressed 70.89 KB +0.05% +30 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 110.11 KB +0.04% +36 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.64 KB +0.02% +43 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.85 KB +0.02% +44 B 🔺
@sentry/nextjs (client) 38.38 KB +0.04% +12 B 🔺
@sentry/sveltekit (client) 35.91 KB +0.09% +33 B 🔺
@sentry/node 134.45 KB +0.07% +96 B 🔺
@sentry/node - without tracing 96.28 KB +0.06% +53 B 🔺
@sentry/aws-serverless 106.52 KB -0.01% -6 B 🔽

View base workflow run

@lforst lforst marked this pull request as ready for review November 20, 2024 15:51
@lforst lforst requested review from a team as code owners November 20, 2024 15:51
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my eyes hurt
LGTM

@lforst lforst merged commit 7e78d67 into develop Nov 20, 2024
182 of 185 checks passed
@lforst lforst deleted the lforst-hoist-everything branch November 20, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants