Skip to content

meta(nuxt): Require minimum Nuxt v3.7.0 #14473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2024
Merged

meta(nuxt): Require minimum Nuxt v3.7.0 #14473

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8be7c3
meta(nuxt): Require minimum Nuxt v3.7.0
s1gr1d Nov 25, 2024
b651026
Merge branch 'develop' into sig/minimum-nuxt-support
s1gr1d Nov 26, 2024
508d50a
delete peers
s1gr1d Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dev-packages/e2e-tests/test-applications/nuxt-3-min/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nuxt-3-min",
"description": "E2E test app for the minimum nuxt 3 version our nuxt SDK supports.",
"description": "E2E test app for the minimum Nuxt 3 version our Nuxt SDK supports.",
"private": true,
"type": "module",
"scripts": {
Expand All @@ -16,15 +16,15 @@
},
"dependencies": {
"@sentry/nuxt": "latest || *",
"nuxt": "3.13.2"
"nuxt": "3.7.0"
},
"devDependencies": {
"@nuxt/test-utils": "^3.14.1",
"@playwright/test": "^1.44.1",
"@sentry-internal/test-utils": "link:../../../test-utils"
},
"overrides": {
"nitropack": "2.9.7",
"@vercel/nft": "^0.27.4"
"nitropack": "2.10.0",
"ofetch": "1.4.0"
}
}
4 changes: 3 additions & 1 deletion packages/nuxt/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@
"access": "public"
},
"peerDependencies": {
"nuxt": "3.x"
"nuxt": ">=3.7.0 || 4.x",
"nitropack": ">=2.10.0",
"ofetch": ">=1.4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, can we do this? Does this not enforce users to specify this version in their own package.json, which they probably do not have? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user does not have to explicitly install it, it just makes sure the dependency tree has the correct version. But if there is a conflicting peer, users might have to install it before npm v6: https://docs.npmjs.com/cli/v10/configuring-npm/package-json#peerdependencies

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm...probably it's better to just not include those peer deps, just to be sure. I'll add them to the docs and list them as a requirement.

},
"dependencies": {
"@nuxt/kit": "^3.13.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/nuxt/src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default defineNuxtModule<ModuleOptions>({
name: '@sentry/nuxt/module',
configKey: 'sentry',
compatibility: {
nuxt: '^3.0.0',
nuxt: '>=3.7.0',
},
},
defaults: {},
Expand Down
Loading