Skip to content

aliu/unleash #15035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 78 commits into from
Closed

aliu/unleash #15035

wants to merge 78 commits into from

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Jan 16, 2025

Ref https://github.com/getsentry/team-replay/issues/514. Adds an integration for tracking Unleash flag evaluations, by patching the isEnabled method prototype.
Ref https://develop.sentry.dev/sdk/expected-features/#feature-flags

Original PR pointing to v8: #14948

mydea and others added 30 commits December 16, 2024 10:29
In order for us to have size-limit comparison etc, we need to ensure CI
runs on v8 & v9 branches too.

Picking this from develop so we also have this on v8 branch!
This release also publishes the AWS lambda layer under the current,
non-version-suffixed layer since it's lagging behind since `8.42.0` with
the introduction of the v8-suffixed layer.
The v8 branch should not publish to the latest layer.
#14709)

We should normalise all paths in ANR events if an appRoot path is
supplied. This is important for the Electron SDK where we normalise
around the app path to keep usernames out of reported events.

Co-authored-by: Abhijeet Prasad <[email protected]>
…#14741)

This isn't exported in types-hoist/index, but we found users can still
import it from a `build/` file. Discussed with @billyvg we don't want
users to accidentally import it this way.

Note we currently use this type in sentry, until
getsentry/sentry#81954 is rolled out.
meta(changelog): Update changelog for 8.46.0
#14755)

Backport of #14753:

Bump
[@prisma/instrumentation](https://github.com/prisma/prisma/tree/HEAD/packages/instrumentation)
from 5.19.1 to 5.22.0.

See https://github.com/prisma/prisma/releases/tag/5.22.0 for release
notes.

This is to take advantage of the following change in 5.22.0:

> In our ongoing effort to stabilize the tracing Preview feature, we’ve
made our spans compliant with OpenTelemetry Semantic Conventions for
Database Client Calls. **This should lead to better compatibility with
tools such as DataDog and Sentry** [emphasis added by me].

There's also this change in
[5.21.0](https://github.com/prisma/prisma/releases/tag/5.21.0):

> The `tracing` Preview feature now has full support for MongoDB with
previously missing functionality now implemented. This is a part of the
ongoing effort to stabilize this Preview feature and release it in
General Availability.

The @dependabot PR for `@prisma/instrumentation` updates this to 6.0.0,
which unfortunately drops Node.JS v18 support, so it isn't suitable for
Sentry v8: #14624
One more release before holidays to get out some v8-backported changes
…ided to `TraceDirective` (#14828)

Backport of #14778

---------

Co-authored-by: Artur <[email protected]>
The v8 suffixed layer lands in the release-registry every time we
publish a release from the v8 branch which not only breaks
https://github.com/getsentry/sentry/blob/c11f4c099257b2388d150f71fb39516e3d3f2328/src/sentry/integrations/aws_lambda/utils.py#L236-L253
but also ends up in the docs as the current version: when using the ARN
dropdown
https://docs.sentry.io/platforms/javascript/guides/aws-lambda/install/cjs-layer/.

This removes the suffix so we get the current major published under the
non-suffixed name.

Follow-up task:
#14842
aliu39 and others added 27 commits January 9, 2025 15:59
Adds a couple of missing changelog entries to the v8 branch, jus to keep
things in sync. Will do the same for `develop` in a sec. Already
includes #14960
It seems that `@types/qs` v 6.9.18 which was just released breaks this
somehow...

Backport of #15001
@aliu39 aliu39 closed this Jan 16, 2025
@aliu39 aliu39 changed the title feat(flags): add Unleash integration ~~add Unleash integration~~ Jan 16, 2025
@aliu39 aliu39 changed the title ~~add Unleash integration~~ aliu/unleash Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.