Skip to content

ref(flags/v8): rename unleash integration param #15345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Feb 7, 2025

Renaming this parameter to keep the name consistent with #15319. We can reuse this generic name for future FF integrations.

The old name is still supported but now marked as deprecated. As a result both params have to be optional, the constructor throws if neither is given. The old name will not be supported in #15343.

@aliu39 aliu39 requested a review from billyvg February 7, 2025 21:05
@aliu39 aliu39 merged commit 9de3ca9 into v8 Feb 20, 2025
124 of 126 checks passed
@aliu39 aliu39 deleted the aliu/unleash-param-v8 branch February 20, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants