-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
node: implement new continuous profiling API spec #15635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
6ea7aeb
types: add startProfilerSession and stopProfilerSession
JonasBa 8d3c390
profiler: add startgst
JonasBa afc305f
profiler: deprecate profileSampler and profilesSampleRate
JonasBa 80e64f8
profiler: add profilelifecycle and profilesessionsamplerate
JonasBa cbbba00
profiler: infer profiling mode based of current options provided
JonasBa 7bc561f
profiler: simplify profiler check
JonasBa 3d4942b
profiling: expect error in preprocessevent
JonasBa b4d8488
profiling: fix tests
JonasBa 7c694b8
test: rename spanProfileUtils to integration.test.ts
JonasBa 9d2a44e
fix formatting
JonasBa 05c6cf8
profiling: implement new profiling API spec (#15636)
JonasBa 08e12ea
fix formatting
JonasBa 43b8aec
setup context
JonasBa 6d16704
add envelope sending test
JonasBa e6fced8
remove log
JonasBa 4b53f24
Merge branch 'develop' into jb/profiling/continuous-profiling-sv1
JonasBa da77c98
profiling: add debug log for mode
JonasBa 757bb6b
profiling: add migration doc
JonasBa 5ef0e8b
Merge branch 'develop' into jb/profiling/continuous-profiling-sv1
s1gr1d 8c325f3
profiling: rename api
JonasBa dc8807c
profiling: rename api
JonasBa 4be5973
profiling: rename api
JonasBa bceec4a
fix linters
JonasBa ba85359
Merge branch 'develop' into jb/profiling/continuous-profiling-sv1
JonasBa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# Continuous Profiling API Changes | ||
|
||
The continuous profiling API has been redesigned to give developers more explicit control over profiling sessions while maintaining ease of use. This guide outlines the key changes. | ||
|
||
## New Profiling Modes | ||
|
||
### profileLifecycle Option | ||
|
||
We've introduced a new `profileLifecycle` option that allows you to explicitly set how profiling sessions are managed: | ||
|
||
- `manual` (default) - You control profiling sessions using the API methods | ||
- `trace` - Profiling sessions are automatically tied to traces | ||
|
||
Previously, the profiling mode was implicitly determined by initialization options. Now you can clearly specify your intended behavior. | ||
|
||
## New Sampling Controls | ||
|
||
### profileSessionSampleRate | ||
|
||
We've introduced `profileSessionSampleRate` to control what percentage of SDK instances will collect profiles. This is evaluated once during SDK initialization. This is particularly useful for: | ||
|
||
- Controlling profiling costs across distributed services | ||
- Managing profiling in serverless environments where you may only want to profile a subset of instances | ||
|
||
### Deprecations | ||
|
||
The `profilesSampleRate` option has been deprecated in favor of the new sampling controls. | ||
The `profilesSampler` option hsa been deprecated in favor of manual profiler control. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add migration docs for this and
profilesSampler
.