test(remix): Run tsc before Remix E2E tests
#16345
Open
+161
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
reviewed
May 20, 2025
| @@ -20,7 +20,7 @@ test('Sends parameterized transaction name to Sentry', async ({ page }) => { | |||
|
|
|||
| test('Sends form data with action span', async ({ page }) => { | |||
| const formdataActionTransaction = waitForTransaction('create-remix-app-express', transactionEvent => { | |||
| return transactionEvent?.spans?.some(span => span.data && span.data['code.function'] === 'action'); | |||
| return transactionEvent?.spans?.some(span => span.data && span.data['code.function'] === 'action') || false; | |||
There was a problem hiding this comment.
q: What does adding || false do here?
There was a problem hiding this comment.
waitForTransaction expects a function returning a boolean, after adding optional chaining, it became boolean | undefined. So, making it false in such cases
...kages/e2e-tests/test-applications/create-remix-app-express/tests/server-transactions.test.ts
Show resolved
Hide resolved
|
@andreiborza - this branch should fail on CI actually. And it does fail on my local. Looks like CI is letting |
onurtemizkan
force-pushed
the
onur/remix-type-tests
branch
from
ab4b1ac to
8fb25f1
Compare
|
Update: I was not able to make this fail on CI (with |
andreiborza
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up: #16336