Skip to content

ref(node): Split up incoming & outgoing http handling #17358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 8, 2025

Just splitting the code into multiple files to make it a bit easier to reason about things & update things in follow up PRs.

Also removing node-fetch types from node package (they are unused there?) and moving http/index.ts and node-fetch/index.ts to top level to avoid an otherwise empty folder.

Also updates the getRequestUrl method for outgoing requests to actually handle ClientRequest properly, this was unnecessarily overloaded before.

Just splitting the code into multiple files to make it a bit easier to reason about things & update things in follow up PRs.

Also removing node-fetch types from node package (they are unused there?) and moving `http/index.ts` and `node-fetch/index.ts` to top level to avoid an otherwise empty folder.
@mydea mydea requested review from Lms24 and andreiborza August 8, 2025 11:02
@mydea mydea self-assigned this Aug 8, 2025
Copy link
Contributor

github-actions bot commented Aug 8, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 24.11 kB - -
@sentry/browser - with treeshaking flags 22.68 kB - -
@sentry/browser (incl. Tracing) 39.83 kB - -
@sentry/browser (incl. Tracing, Replay) 77.92 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.77 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 82.63 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 94.73 kB - -
@sentry/browser (incl. Feedback) 40.77 kB - -
@sentry/browser (incl. sendFeedback) 28.77 kB - -
@sentry/browser (incl. FeedbackAsync) 33.66 kB - -
@sentry/react 25.83 kB - -
@sentry/react (incl. Tracing) 41.8 kB - -
@sentry/vue 28.59 kB - -
@sentry/vue (incl. Tracing) 41.64 kB - -
@sentry/svelte 24.14 kB - -
CDN Bundle 25.62 kB - -
CDN Bundle (incl. Tracing) 39.72 kB - -
CDN Bundle (incl. Tracing, Replay) 75.77 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 81.19 kB - -
CDN Bundle - uncompressed 74.89 kB - -
CDN Bundle (incl. Tracing) - uncompressed 117.52 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 231.78 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 244.38 kB - -
@sentry/nextjs (client) 43.83 kB - -
@sentry/sveltekit (client) 40.27 kB - -
@sentry/node-core 47.78 kB +0.11% +48 B 🔺
@sentry/node 146.66 kB +0.03% +40 B 🔺
@sentry/node - without tracing 91.87 kB +0.05% +44 B 🔺
@sentry/aws-serverless 103.3 kB +0.04% +31 B 🔺

View base workflow run

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I probably overlooked the fetch types when I moved things to node-core.

@mydea mydea merged commit 06105b6 into develop Aug 11, 2025
138 checks passed
@mydea mydea deleted the fn/split-http-instrumentation branch August 11, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants