Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add apf build #1995

Closed
wants to merge 10 commits into from
Closed

[WIP] Add apf build #1995

wants to merge 10 commits into from

Conversation

cromefire
Copy link
Contributor

@cromefire cromefire commented Apr 4, 2019

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Truly fixes #1979

Signed-off-by: cromefire <[email protected]>
Signed-off-by: cromefire <[email protected]>
@cromefire
Copy link
Contributor Author

@HazAT Please have a look, why the bundles do not build

@HazAT
Copy link
Member

HazAT commented Apr 8, 2019

Maybe you can build your PR on this
#1999
should make it easier

@cromefire
Copy link
Contributor Author

cromefire commented Apr 8, 2019

Yes I tried to replicate that, but I have problems with the paths, it doesn't work, but it should

@abhijeet-sonaje
Copy link

any updates on this?

@cromefire
Copy link
Contributor Author

Yes I want to finish it in the next few days

@cromefire
Copy link
Contributor Author

If I get that paths problem fixed

@cromefire
Copy link
Contributor Author

I got the basic thing working, but not yet for all packages, but I guess you can start reviewing it

@cromefire cromefire marked this pull request as ready for review April 26, 2019 20:28
@cromefire cromefire requested a review from kamilogorek as a code owner April 26, 2019 20:28
Signed-off-by: cromefire <[email protected]>
Signed-off-by: cromefire <[email protected]>
Signed-off-by: cromefire <[email protected]>
Signed-off-by: cromefire <[email protected]>
@cromefire
Copy link
Contributor Author

There are some wired resolving issues (typescript shows, that it get's resolved, but it doesn't).

Created an issue over at typescript

@HazAT
Copy link
Member

HazAT commented Apr 29, 2019

@cromefire Thank you for the work you've put into this so far but I am not sure if we will merge this soonish.
This adds at least a 5x multiplier for to our build times + artifacts. While most of it is automated I am not sure if I want to still maintain this for a relatively small benefit right now.

@cromefire
Copy link
Contributor Author

This adds at least a 5x multiplier for to our build times + artifacts

It's mostly parallelized

@HazAT
Copy link
Member

HazAT commented Jul 8, 2019

@cromefire Thanks again for the work you put into this. I will close this PR now since it's heavily outdated and I don't see a real reason to provide an APF build atm.

@HazAT HazAT closed this Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow apf
3 participants