ref(tracing): Add transaction source to default router #5386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
lforst and
Lms24
and removed request for
a team
15 tasks
lforst
approved these changes
Jul 7, 2022
size-limit report 📦
|
|
Do we have integration tests for the default router? If yes, we could try to add a test that the source really ends up in the event payload. (Optional, can also be done in a separate PR) |
|
Yes! We can take a look with integration tests. Will add. |
Lms24
approved these changes
Jul 7, 2022
AbhiPrasad
force-pushed
the
abhi-default-router-source
branch
from
f445976 to
d265a85
Compare
AbhiPrasad
commented
Jul 7, 2022
Comment on lines
+211
to
+216
| ...(parentContextFromHeader && { | ||
| metadata: { | ||
| ...context.metadata, | ||
| ...parentContextFromHeader.metadata, | ||
| }, | ||
| }), |
There was a problem hiding this comment.
Had to add this to make the integration tests pass. TODO on coming back to it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5345