ref(serverless): Add transaction source #5394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
size-limit report 📦
|
lobsterkatie
reviewed
Jul 8, 2022
| @@ -87,7 +87,7 @@ function _wrapHttpFunction(fn: HttpFunction, wrapOptions: Partial<HttpFunctionWr | |||
| name: `${reqMethod} ${reqUrl}`, | |||
| op: 'gcp.function.http', | |||
| ...traceparentData, | |||
| metadata: { baggage }, | |||
| metadata: { baggage, source: 'url' }, | |||
There was a problem hiding this comment.
Perhaps dumb question, but is parameterization even a thing in this context?
I'm not super familiar with GCP, but it seems from this and this and this like data can only be passed either in the query string or in the request body.
If that's true, then I think we can switch this to 'route', because it then isn't high cardinality. (That might not be strictly true, because the region part of the URL might vary, but we can just substitute a parameter there if we want.)
There was a problem hiding this comment.
I mostly just defaulted to url here to stay on the safe side - but I agree with your reasoning, will change to route.
AbhiPrasad
force-pushed
the
abhi-serverless-transaction-source
branch
from
cda2aae to
3590cc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #5345
Decided to go with
componentfor the serverless functions as they are function names as transaction name.