-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(types): Add PolymorphicRequest
type
#5744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ea549fe
to
d86cd7d
Compare
size-limit report 📦
|
d86cd7d
to
6b45a4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this more explicit.
Please fix tests and linting. Then it's good to go.
Yeah, of course. This is what I get for pushing right before I go to bed and not waiting for CI... I don't get a chance to fix all my dumb mistakes, LOL. |
6b45a4d
to
270809e
Compare
This is a change which comes out of a code review of #5703, moving the
CrossPlatformType
from@sentry/utils
to@sentry/types
and renaming itPolymorphicRequest
(to match the existingPolymorphicEvent
). Because it affects a number of files, I decided to pull it into its own PR, just to not confuse things in that one.