Skip to content

chore(replay): Use Monorepo's toplevel .npmignore #6361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 1, 2022

This PR removes Replay's empty .npmignore file as we can use the monorepo's top-level .npmignore file. When running build:npm, this top-level ignore file is copied into the build/npm directory where it is used to control what's going into the NPM tarball. Because the Replay package now has the same contents and structure as all our other packages, we don't need a package-specific ignore file.

ref #6280

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.57 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 60.59 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.36 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 54.15 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.12 KB (0%)
@sentry/browser - Webpack (minified) 65.75 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.14 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 45.99 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.45 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.88 KB (+0.02% 🔺)
@sentry/replay index.js 37.2 KB (0%)
@sentry/replay - Webpack (gzipped + minified) 37.17 KB (0%)
@sentry/replay - Webpack (minified) 124.99 KB (0%)

@Lms24 Lms24 requested a review from mydea December 1, 2022 10:22
@Lms24 Lms24 merged commit 7533e77 into master Dec 1, 2022
@Lms24 Lms24 deleted the lms-replay-cleanup-npmignore branch December 1, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants