-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
build(replay): Generate Replay CDN bundles #6391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Dec 2, 2022
mydea
reviewed
Dec 2, 2022
size-limit report 📦
|
lobsterkatie
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small questions, but otherwise LGTM!
af20929
to
b35efa8
Compare
mydea
approved these changes
Dec 2, 2022
Co-authored-by: Katie Byers <[email protected]>
b35efa8
to
4080cd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a rollup config to generate an addon CDN bundle for the Replay integration. Usage of this bundle is identical to our other integration CDN bundles in the sense that the bundle has to be added in addition to the regular browser (or browser+tracing) bundle.
As of this PR, three bundles will be generated into
build/bundles
:replay.js
(the unminified bundle with debug output)replay.min.js
(the minified bundle without debug output)replay.debug.min.js
(the minified bundle with debug output)For now, we'll only generate ES6 bundles but we can add ES5 versions if requested later on.
ref #6362