feat(replay): Stop without retry when receiving bad API response #6773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Jan 16, 2023
| @@ -234,6 +234,7 @@ export class ReplayContainer implements ReplayContainerInterface { | |||
| this._stopRecording?.(); | |||
| this.eventBuffer?.destroy(); | |||
| this.eventBuffer = null; | |||
| this._debouncedFlush.cancel(); | |||
There was a problem hiding this comment.
Just a small thing I noticed while debugging tests.
mydea
commented
Jan 16, 2023
| @@ -907,7 +908,7 @@ export class ReplayContainer implements ReplayContainerInterface { | |||
| if (rateLimitDuration > 0) { | |||
| __DEBUG_BUILD__ && logger.warn('[Replay]', `Rate limit hit, pausing replay for ${rateLimitDuration}ms`); | |||
| this.pause(); | |||
| this._debouncedFlush && this._debouncedFlush.cancel(); | |||
| this._debouncedFlush.cancel(); | |||
There was a problem hiding this comment.
This is set in the constructor, so no need to check for existence here.
mydea
commented
Jan 16, 2023
| @@ -5,7 +5,7 @@ import type { DomHandler } from './../types'; | |||
| import type { MockSdkParams } from './mockSdk'; | |||
| import { mockSdk } from './mockSdk'; | |||
|
|
|||
| export async function resetSdkMock({ replayOptions, sentryOptions }: MockSdkParams): Promise<{ | |||
| export async function resetSdkMock({ replayOptions, sentryOptions, autoStart }: MockSdkParams): Promise<{ | |||
There was a problem hiding this comment.
Just noticed that this was not actually passed through.
size-limit report 📦
|
Lms24
approved these changes
Jan 16, 2023
mydea
force-pushed
the
fn/replay-error-response
branch
from
38445f9 to
6197d34
Compare
|
ref #6770 as either here or there we should adjust the integration test. |
mydea
force-pushed
the
fn/replay-error-response
branch
from
6197d34 to
7e93d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #6765!
This ensures that when we hit a "bad" API response, instead of continuing - which we do now, which will lead to missing segments - we stop the replay immediately.
We do not do any retries in this case, as that could lead to us e.g. hammering the API when there is a problem, which we need to avoid.
I've spent way to much time getting this to work in the "classic" test setup we have, and eventually gave up and wrote a integration test instead. For what it's worth, the problem seems to be with resetting stuff & mocks when we have multiple tests in a row (it worked when running tests one by one). It is very weird, but a problem to be solved with more time, I'd say. For now, the test should be good.