Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set http breadcrumb level based on response code #940

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Set http breadcrumb level based on response code #940

merged 1 commit into from
Sep 4, 2024

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Aug 14, 2024 •
edited
Loading

image

I think it makes sense to set 4XX response codes to warning instead of error.

Part of getsentry/team-sdks#100

@cleptric cleptric requested a review from stayallive August 14, 2024 01:17
@cleptric cleptric self-assigned this Aug 14, 2024
@cleptric cleptric mentioned this pull request Aug 14, 2024
Open
stayallive
stayallive approved these changes Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@cleptric cleptric merged commit 14e828d into master Sep 4, 2024
24 checks passed
@cleptric cleptric deleted the update-http-client-breadcrumb-level branch September 4, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stayallive stayallive stayallive approved these changes

Assignees

@cleptric cleptric

Labels
Type: Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cleptric @stayallive